zhuzhurk commented on a change in pull request #10079: [FLINK-14594] Fix
matching logics of ResourceSpec/ResourceProfile/Resource considering double
values
URL: https://github.com/apache/flink/pull/10079#discussion_r345555831
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
##########
@@ -150,21 +156,23 @@ public ResourceProfile(
extendedResources);
}
- @VisibleForTesting
- public ResourceProfile(double cpuCores, MemorySize taskHeapMemory) {
Review comment:
These constructors for combinations of different given resources and
different raw/advanced types is not flexible. It's also not clear to track the
resources that are set.
So I think it's better to introduce a builder for ResourceProfile, as
proposed in FLINK-14733.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
