KurtYoung commented on a change in pull request #10160: 
[FLINK-14723][table-planner-blink] Improve some code of computed column in 
planner
URL: https://github.com/apache/flink/pull/10160#discussion_r345561333
 
 

 ##########
 File path: 
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/operations/JavaDataStreamQueryOperation.java
 ##########
 @@ -38,6 +38,11 @@
 @Internal
 public class JavaDataStreamQueryOperation<E> implements QueryOperation {
 
+       // JavaDataStreamQueryOperation represent a registered DataStream from 
`registerDataStream` method
 
 Review comment:
   I don't get why we want to keep this as comments? It's just a table name, 
and due to some reason we lost it in the old code, but added back now. We don't 
have to record all the reasons behind this in comment. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to