Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1255#discussion_r43008448
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java
 ---
    @@ -1138,12 +1138,13 @@ private DistributionPattern 
connectJobVertices(Channel channel, int inputNumber,
                
                if (channel.getShipStrategy() == 
ShipStrategyType.PARTITION_RANGE) {
                        
    -                   final DataDistribution dataDistribution = 
channel.getDataDistribution();
    +                   DataDistribution dataDistribution = 
channel.getDataDistribution();
                        if (dataDistribution != null) {
                                
sourceConfig.setOutputDataDistribution(dataDistribution, outputIndex);
                        } else {
    -                           throw new RuntimeException("Range partitioning 
requires data distribution");
    -                           // TODO: inject code and configuration for 
automatic histogram generation
    --- End diff --
    
    As the TODO comment says, here should go the sampling and distribution 
building code :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to