[ 
https://issues.apache.org/jira/browse/FLINK-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974124#comment-16974124
 ] 

Chesnay Schepler commented on FLINK-14740:
------------------------------------------

only if the names match. The TaskMetricGroup uses the vertex id and vertex name 
as a key. Thus, as long as operator names are unique you don't have a problem.

And you need unique operator names anyway since, as outlined before, there's no 
way to correlate the operator ID with a specific operator.

> Create OperatorID for OperatorMetricGroup which in batch job 
> -------------------------------------------------------------
>
>                 Key: FLINK-14740
>                 URL: https://issues.apache.org/jira/browse/FLINK-14740
>             Project: Flink
>          Issue Type: Wish
>          Components: Runtime / Metrics
>            Reporter: lining
>            Priority: Major
>
> *In current design:*
> The DataSet job uses VertexID as the OperatorID in the OperatorMetricGroup 
> (ps:TaskMetricGroup.getOrAddOperator (string name)).
> If two operators in the same vertex have the same name, they will overwrite 
> each other in the TaskMetricGroup.
> *Proposal:*
> We could add the OperatorID to the operator of the dataset.
> {code:java}
> for (TaskInChain tic : this.chainedTasksInSequence) {
>    TaskConfig t = new 
> TaskConfig(tic.getContainingVertex().getConfiguration());
>    Integer nodeId = tic.getPlanNode().getOptimizerNode().getId();
>    OperatorID operatorID = this.nodeId2OperatorId.get(nodeId);
>    if(operatorID == null) {
>       operatorID = new OperatorID();
>       this.nodeId2OperatorId.put(nodeId, operatorID);
>    }
>    t.addChainedTask(tic.getChainedTask(), tic.getTaskConfig(), 
> tic.getTaskName(), operatorID.toString());
> }
> {code}
> Then we could get id from TaskInfo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to