wuchong commented on a change in pull request #10144:
[FLINK-14613][table-planner-blink] Fix temporal table join when containing
multiple keyfields with UDF
URL: https://github.com/apache/flink/pull/10144#discussion_r346853752
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/LookupJoinITCase.scala
##########
@@ -84,6 +84,20 @@ class LookupJoinITCase extends StreamingTestBase {
.field("name", Types.STRING)
.build()
+ val userDataWithSameAge = List(
+ (11, 1L, "Julian"),
+ (22, 2L, "Jark"),
+ (33, 3L, "Fabian"),
+ (11, 4L, "Hello world")
+ )
+
+ val userWithSameAgeTableSourceWith2Keys =
InMemoryLookupableTableSource.builder()
Review comment:
Could we reuse the existing testing data or improve the existing data?
We should avoid introducing to much testing data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
