azagrebin commented on a change in pull request #10034: [FLINK-14400] Shrink
scope of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r347275763
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -490,14 +497,17 @@ private static void checkTempDirs(String[] tmpDirs)
throws IOException {
}
public static ResourceProfile computeSlotResourceProfile(int
numOfSlots, long managedMemorySize) {
- int managedMemoryPerSlotMB = (int)
bytesToMegabytes(managedMemorySize / numOfSlots);
+ // TODO: before operators separate on-heap/off-heap managed
memory, we use on-heap managed memory to denote total managed memory
+ return computeSlotResourceProfile(numOfSlots,
Collections.singletonMap(MemoryType.HEAP, managedMemorySize));
Review comment:
True, we could but it should completely disappear soon after #10161.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
