GJL commented on a change in pull request #10237: [FLINK-14362][runtime] Change 
DefaultSchedulingResultPartition to return correct partition state
URL: https://github.com/apache/flink/pull/10237#discussion_r347859762
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultResultPartition.java
 ##########
 @@ -42,17 +43,21 @@
 
        private final ResultPartitionType partitionType;
 
+       private final Supplier<ResultPartitionState> 
resultPartitionStateSupplier;
+
        private DefaultExecutionVertex producer;
 
        private final List<DefaultExecutionVertex> consumers;
 
        DefaultResultPartition(
                        IntermediateResultPartitionID partitionId,
                        IntermediateDataSetID intermediateDataSetId,
-                       ResultPartitionType partitionType) {
+                       ResultPartitionType partitionType,
+                       Supplier<ResultPartitionState> 
resultPartitionStateSupplier) {
 
 Review comment:
   Just an observation: Isn't this class now very similar to 
`TestingSchedulingResultPartition`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to