hequn8128 commented on a change in pull request #10188: [FLINK-14066][python]
Support to install pyflink in windows
URL: https://github.com/apache/flink/pull/10188#discussion_r347871028
##########
File path: flink-python/setup.py
##########
@@ -75,8 +85,9 @@
print("Temp path for symlink to parent already exists
{0}".format(TEMP_PATH),
file=sys.stderr)
sys.exit(-1)
-
- FLINK_HOME = os.path.abspath("../build-target")
+ java_version = VERSION.replace(".dev0", "-SNAPSHOT")
Review comment:
How about renaming it to flink_version? I was first confused that it is the
version of jvm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
