xintongsong commented on a change in pull request #10161:
[FLINK-13986][runtime] Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347881402
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -254,11 +230,24 @@
public static final ConfigOption<String> TOTAL_PROCESS_MEMORY =
key("taskmanager.memory.total-process.size")
.noDefaultValue()
- .withDeprecatedKeys(TASK_MANAGER_HEAP_MEMORY.key())
+ .withDeprecatedKeys("taskmanager.heap.size")
.withDescription("Total Process Memory size for the
TaskExecutors. This includes all the memory that a"
+ " TaskExecutor consumes, consisting of Total
Flink Memory, JVM Metaspace, and JVM Overhead. On"
+ " containerized setups, this should be set to
the container memory.");
+ /**
+ * JVM heap size (in megabytes) for the TaskManagers.
+ *
+ * @deprecated use {@link #TOTAL_PROCESS_MEMORY}
+ */
+ @Deprecated
+ public static final ConfigOption<Integer> TASK_MANAGER_HEAP_MEMORY_MB =
Review comment:
I think this way it looks more clear to put deprecated option close to the
new alternative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
