[
https://issues.apache.org/jira/browse/FLINK-14812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977939#comment-16977939
]
Eui Heo edited comment on FLINK-14812 at 11/20/19 12:10 AM:
------------------------------------------------------------
Your approach looks good and clear. However, to my knowledge, volume types that
can be shared between pods are often not available depending on the environment.
Note:
[https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes]
Volume mount approach have the advantage of not requiring any modifications to
the Flink scripts, but this approach seems to be burdensome to create and
manage additional k8s resources such as Volume and VolumeMount and only
available in environments that provide volumes that support ReadOnlyMany mode.
The metric lib is included in the Flink distribution binary and in the
“/opt/flink/opt” path of the official docker image also. If only new
environment variables are added, the metric function can be used, so this
approach seems to be more simpler solution in my opinion.
was (Author: elanv):
Your approach looks good and clear. However, to my knowledge, volume types that
can be shared between pods are often not available depending on the environment.
Note:
[https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes]
Volume mount approach have the advantage of not requiring any modifications to
the Flink scripts, but this approach seems to be burdensome to create and
manage additional k8s resources such as Volume and VolumeMount and only
available in environments that provide volumes that support ReadOnlyMany mode.
The metric lib is included in the Flink distribution binary and in the
“/opt/flink/opt” path of the official docker image also. If only new
environment variables are added, the metric function can be used, so this
approach seems to be a simpler solution in my opinion.
> Add metric libs to Flink classpath with an environment variable.
> ----------------------------------------------------------------
>
> Key: FLINK-14812
> URL: https://issues.apache.org/jira/browse/FLINK-14812
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes, Deployment / Scripts
> Reporter: Eui Heo
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To use the Flink metric lib you need to add it to the flink classpath. The
> documentation explains to put the jar file in the lib path.
> https://ci.apache.org/projects/flink/flink-docs-stable/monitoring/metrics.html#prometheus-orgapacheflinkmetricsprometheusprometheusreporter
> However, to deploy metric-enabled Flinks on a kubernetes cluster, we have the
> burden of creating and managing another container image. It would be more
> efficient to add the classpath using environment variables inside the
> constructFlinkClassPath function in the config.sh file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
