zhuzhurk opened a new pull request #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance URL: https://github.com/apache/flink/pull/10287 ## What is the purpose of the change This PR is to remove the unnecessary param `JobGraph` from `SchedulingStrategyFactory#createInstance`. The JobGraph is not used at the moment. It provides additional information but exposes too much internal implementations and there can be actions which are not desired to be invoked by users. In the future we can provide needed information for custom SchedulingStrategy in a well defined way. ## Brief change log - *Removed param JobGraph from SchedulingStrategyFactory#createInstance* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
