dianfu commented on a change in pull request #10017: [FLINK-14019][python] add 
support for managing environment and dependencies of Python UDF in Flink Python 
API
URL: https://github.com/apache/flink/pull/10017#discussion_r349911648
 
 

 ##########
 File path: 
flink-python/src/main/java/org/apache/flink/python/AbstractPythonFunctionRunner.java
 ##########
 @@ -198,19 +174,14 @@ public void open() throws Exception {
                Struct pipelineOptions = 
PipelineOptionsTranslation.toProto(portableOptions);
 
                jobBundleFactory = createJobBundleFactory(pipelineOptions);
+               // The creation of stageBundleFactory depends on the 
initialized environment manager.
 
 Review comment:
   Move `environmentManager.open();` before portableOptions statement? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to