RustedBones commented on issue #10285: [FLINK-14896] [flink-kinesis-connector] 
Set jackson and guava dependency to flink-shaded
URL: https://github.com/apache/flink/pull/10285#issuecomment-557874361
 
 
   You are right @zentol. 
   
   I started to change my code to both package the proper `jackson` lib or to 
avoid accessing the shaded `dynamodb` sbk from flink.
   
   I noticed however the following: The classes 
[`AWSUtil.java`](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java),
 
[`BeanDeserializerModifierForIgnorables.java`](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/BeanDeserializerModifierForIgnorables.java)
 and 
[`DynamoDBStreamsSchema.java`](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/DynamoDBStreamsSchema.java)
 are relying on `jackson` library to be in the classpath.
   
   I think this worked because the `jackson` is in most cases in the classpath 
and the API used in those classes did not change for a long time, limiting the 
risk of incompatible version.
   
   Since there is direct usage of `jackson` made in the connector, I think the 
lib must be shaded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to