RustedBones commented on a change in pull request #10285: [FLINK-14896]
[flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
URL: https://github.com/apache/flink/pull/10285#discussion_r349914362
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -193,25 +193,30 @@ under the License.
<artifactSet
combine.children="append">
<includes>
<include>com.amazonaws:*</include>
+
<include>com.fasterxml:*</include>
<include>com.google.protobuf:*</include>
<include>org.apache.httpcomponents:*</include>
<!--
Java 11 specific inclusion; should be a no-op for other versions -->
<include>javax.xml.bind:jaxb-api</include>
</includes>
</artifactSet>
<relocations
combine.children="override">
- <!-- DO NOT
RELOCATE GUAVA IN THIS PACKAGE -->
<relocation>
-
<pattern>com.google.protobuf</pattern>
-
<shadedPattern>org.apache.flink.kinesis.shaded.com.google.protobuf</shadedPattern>
+
<pattern>com.amazonaws</pattern>
+
<shadedPattern>org.apache.flink.streaming.kinesis.shaded.com.amazonaws</shadedPattern>
</relocation>
<relocation>
-
<pattern>com.amazonaws</pattern>
-
<shadedPattern>org.apache.flink.kinesis.shaded.com.amazonaws</shadedPattern>
+
<pattern>com.fasterxml</pattern>
+
<shadedPattern>org.apache.flink.streaming.kinesis.shaded.com.fasterxml</shadedPattern>
+ </relocation>
+ <!-- DO NOT
RELOCATE GUAVA IN THIS PACKAGE -->
Review comment:
Why is guava not included ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
