zhuzhurk commented on a change in pull request #10232: [FLINK-14314][runtime] 
Allocate shared slot resources respecting the resources of all vertices in the 
group
URL: https://github.com/apache/flink/pull/10232#discussion_r349930384
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/runtime/utils/BatchAbstractTestBase.java
 ##########
 @@ -47,7 +47,7 @@
 
        private static Configuration getConfiguration() {
                Configuration config = new Configuration();
-               config.setString(TaskManagerOptions.LEGACY_MANAGED_MEMORY_SIZE, 
"100m");
+               config.setString(TaskManagerOptions.LEGACY_MANAGED_MEMORY_SIZE, 
"200m");
 
 Review comment:
   Forgot to update it that this fix is not needed now, since changes of 
FLINK-13708 are merged.
   The issue in FLINK-13708 may result in large regions combined by vertices 
from different jobs. Solving it also make the existing tests able to pass with 
current managed memory setting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to