[ 
https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984810#comment-14984810
 ] 

ASF GitHub Bot commented on FLINK-2797:
---------------------------------------

Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1214#discussion_r43600897
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
 ---
    @@ -36,28 +31,16 @@
     
        private static final Logger LOG = 
LoggerFactory.getLogger(StreamContextEnvironment.class);
     
    -   private final List<URL> jars;
    -
    -   private final List<URL> classpaths;
    -   
    -   private final Client client;
    +   private final ContextEnvironment ctx;
     
        private final ClassLoader userCodeClassLoader;
    -   
    -   private final boolean wait;
     
    -   protected StreamContextEnvironment(Client client, List<URL> jars, 
List<URL> classpaths, int parallelism,
    -                   boolean wait) {
    -           this.client = client;
    -           this.jars = jars;
    -           this.classpaths = classpaths;
    -           this.wait = wait;
    -           
    -           this.userCodeClassLoader = 
JobWithJars.buildUserCodeClassLoader(jars, classpaths,
    -                           getClass().getClassLoader());
    +   protected StreamContextEnvironment(ContextEnvironment ctx) {
    +           this.ctx = ctx;
    +           this.userCodeClassLoader = 
JobWithJars.buildUserCodeClassLoader(ctx.getJars(), ctx.getClasspaths(), 
getClass().getClassLoader());
    --- End diff --
    
    I'm not very familiar with classloaders. Is it necessary that the 
classloader for Streaming jobs be built here and not via the usual 
`Program#getUserCodeClassLoader` in `Client` class?


> CLI: Missing option to submit jobs in detached mode
> ---------------------------------------------------
>
>                 Key: FLINK-2797
>                 URL: https://issues.apache.org/jira/browse/FLINK-2797
>             Project: Flink
>          Issue Type: Bug
>          Components: Command-line client
>    Affects Versions: 0.9, 0.10
>            Reporter: Maximilian Michels
>            Assignee: Sachin Goel
>             Fix For: 0.10
>
>
> Jobs can only be submitted in detached mode using YARN but not on a 
> standalone installation. This has been requested by users who want to submit 
> a job, get the job id, and later query its status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to