sunhaibotb commented on a change in pull request #10151: [FLINK-14231] Handle
the processing-time timers before closing operator to properly support endInput
URL: https://github.com/apache/flink/pull/10151#discussion_r349979144
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -205,6 +206,8 @@
private Long syncSavepointId = null;
+ private final Map<StreamOperator<?>, ProcessingTimeServiceImpl>
processingTimeServices;
Review comment:
> map value: It's better to specify an interface, not a concrete
implementation to depend on it less.
The methods `quiesce` and `getTimersDoneFutureAfterQuiescing` need to be
added in the processing time service, but the `ProcessingTimeService` interafce
is user-oriented, so we don't want to change it due to the runtime needs. On
the other hand, `StreamTask` understands `ProcessingTimeServiceImpl` because it
uses `ProcessingTimeServiceImpl` to build instances in
`#getProcessingTimeService`. So it should be possible to use the concrete
implementation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
