hequn8128 commented on a change in pull request #10103: 
[FLINK-14506][python][build] Improve the release script for Python API release 
package
URL: https://github.com/apache/flink/pull/10103#discussion_r350021854
 
 

 ##########
 File path: flink-python/dev/lint-python.sh
 ##########
 @@ -303,7 +352,7 @@ function install_environment() {
     # step-3 install python environment whcih includes
     # 3.5 3.6 3.7
     print_function "STEP" "installing python environment..."
 
 Review comment:
   Move this print into the `if`? because the installation may not be called if 
it returns false.
   Same for other commands.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to