TisonKun commented on a change in pull request #10313: [FLINK-14840] Use 
Executor interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r350562168
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
 ##########
 @@ -523,12 +525,12 @@ public void stop(SessionContext session) {
                }
 
                // store the result with a unique id (the job id for now)
-               final String resultId = jobGraph.getJobID().toString();
 
 Review comment:
   Is `JobID` here possibly different from the actual `JobID` on running? I'm 
thinking of introduce a `getJobID` method in `Pipeline` even. A Pipeline 
corresponds to a job and is able to hold a job id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to