AHeise commented on a change in pull request #10336:
[FLINK-14935][task,runtime] Use RunnableWithException in the Mailbox
URL: https://github.com/apache/flink/pull/10336#discussion_r351329999
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/Mail.java
##########
@@ -61,11 +62,7 @@ public String toString() {
return String.format(descriptionFormat, descriptionArgs);
}
- public void run() {
- try {
- runnable.run();
- } catch (Exception e) {
- throw new IllegalStateException("Cannot process mail "
+ toString(), e);
Review comment:
That's exactly what I meant by moving exception handling out. Now we have 3
places instead of 1 where we need to wrap it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
