[ 
https://issues.apache.org/jira/browse/FLINK-14717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984976#comment-16984976
 ] 

Chesnay Schepler commented on FLINK-14717:
------------------------------------------

I'm not a friend of endpoints drilling infinitely into sub-structures; the 
argument cannot be "well subtasks are part of a job, hence it's fine to expose 
information on job-level handlers".
Not only does this invalidate the existence of many existing handlers (all 
vertex/subtask handlers, obviously) it also generates a hell of a lot of waste 
if you are not interested in the exceptions further down.

It's also utterly inflexible to do it this way; with a limit of N exceptions to 
be displayed, if any subtask has failed more than N times you cannot access the 
remaining exceptions without continuously upping the exception limit.
Instead. if one is interested in the history of a particuler vertex, then it 
should be possible to query exactly that.

> JobExceptionsHandler show exceptions of prior  attempts 
> --------------------------------------------------------
>
>                 Key: FLINK-14717
>                 URL: https://issues.apache.org/jira/browse/FLINK-14717
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Web Frontend
>            Reporter: lining
>            Priority: Major
>         Attachments: screenshot-1.png
>
>
> *Current*
> The job's exceptions just show current attempt’s exceptions in web UI.(ps: 
> [code|https://github.com/apache/flink/blob/34b5399f4effb679baabd8bca312cbf92ec34165/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandler.java#L97-L98])
> If the job failovers, we couldn't see any prior attempts' exceptions.
> *Proposal*
> We could use executionVertex.getPriorExecutionAttempt to get prior attempt in 
> JobExceptionsHandler.
> {code:java}
> for (int i = task.getAttemptNumber() - 1; i >= 0; i--) {
>   task = executionVertex.getPriorExecutionAttempt(i);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to