TisonKun commented on a change in pull request #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408#discussion_r353570641
########## File path: flink-core/src/main/java/org/apache/flink/core/execution/JobListener.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.execution; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.JobID; + +/** + * A listener that is notified on specific job status changed. + */ +@PublicEvolving +public interface JobListener { + + /** + * Callback on job submission succeeded. + * + * @param jobID of the submitted job + */ + void onJobSubmitted(JobID jobID); Review comment: For `onJobExecuted`, what do you want to be called back? Is it necessary to be a `JobExecutionResult` i.e. execute attach? Or a `DetachedJobExecutionResult` i.e. execute detached is ok? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
