KurtYoung commented on a change in pull request #10399:
[FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType
in blink planner
URL: https://github.com/apache/flink/pull/10399#discussion_r353579374
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -386,10 +386,20 @@ object GenerateUtils {
generateNonNullLiteral(literalType, fieldTerm, literalType)
case TIMESTAMP_WITH_LOCAL_TIME_ZONE =>
- val millis =
unixTimestampToLocalDateTime(literalValue.asInstanceOf[Long])
+ val fieldTerm = newName("timestampWithLocalZone")
+ val millis = unixTimestampToLocalDateTime(
+ literalValue.asInstanceOf[TimestampString].getMillisSinceEpoch)
.atZone(ctx.tableConfig.getLocalTimeZone)
.toInstant.toEpochMilli
- generateNonNullLiteral(literalType, millis + "L", literalValue)
+ val nanoOfMillis = SqlDateTimeUtils.getNanoOfMillisSinceEpoch(
Review comment:
Why not getting nano from the previous `Instant` you got
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
