docete commented on a change in pull request #10399:
[FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType
in blink planner
URL: https://github.com/apache/flink/pull/10399#discussion_r353631739
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
##########
@@ -76,7 +76,8 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
case LogicalTypeRoot.DATE => createSqlType(DATE)
case LogicalTypeRoot.TIME_WITHOUT_TIME_ZONE => createSqlType(TIME)
case LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE =>
- createSqlType(TIMESTAMP_WITH_LOCAL_TIME_ZONE)
+ val lzTs = t.asInstanceOf[LocalZonedTimestampType]
Review comment:
There is only one Kind for TIMESTAMP_WITH_LOCAL_TIME_ZONE now.
If we allow define ROWTIME on TIMESTAMP_WITH_LOCAL_TIME_ZONE column, it
should be handled like TIMESTAMP_WITHOUT_TIME_ZONE in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
