wuchong commented on a change in pull request #10403: [FLINK-14645][table]
Support to keep nullability and precision when converting DataTypes to
properties
URL: https://github.com/apache/flink/pull/10403#discussion_r353719618
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableFactory.java
##########
@@ -119,7 +126,17 @@ private HBaseTableSchema validateTableSchema(TableSchema
schema) {
String[] qualifierNames =
familyType.getFieldNames();
TypeInformation[] qualifierTypes =
familyType.getFieldTypes();
for (int j = 0; j < familyType.getArity(); j++)
{
- hbaseSchema.addColumn(name,
qualifierNames[j], qualifierTypes[j].getTypeClass());
+ // HBase connector doesn't support
LocalDateTime
+ // use Timestamp as conversion class
for now.
+ Class clazz =
qualifierTypes[j].getTypeClass();
+ if (LocalDateTime.class.equals(clazz)) {
+ clazz = Timestamp.class;
Review comment:
You are right, currently HBase connector only support atomic types as
columns (HBase qualifier).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
