carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353878204
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java ########## @@ -113,4 +126,16 @@ public void close() throws RocksDBException { } IOUtils.closeQuietly(batch); } + + private void flushIfNeeded() throws RocksDBException { + boolean needFlush = batch.count() == capacity || (batchSize > 0 && batch.getDataSize() >= batchSize); + if (needFlush) { + flush(); + } + } + + @VisibleForTesting + long getDataSize() { + return batch.getDataSize(); Review comment: A little bit curious about how much the new implementation (additional calculation on data size) could improve the performance. Mind adding some comparison between the old (jni call) and new implementation here through micro benchmark? @klion26 Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services