zhijiangW commented on a change in pull request #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#discussion_r354128492
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesWorkerNode.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes; + +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.clusterframework.types.ResourceIDRetrievable; + +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * A stored Kubernetes worker, which contains the kubernetes pod. + */ +public class KubernetesWorkerNode implements ResourceIDRetrievable { + private final ResourceID resourceID; + + /** + * This pattern should be updated when {@link KubernetesResourceManager#TASK_MANAGER_POD_FORMAT} changed. + */ + private static final Pattern TASK_MANAGER_POD_PATTERN = Pattern.compile("\\S+-taskmanager-([\\d]+)-([\\d]+)"); + + KubernetesWorkerNode(ResourceID resourceID) { + this.resourceID = resourceID; + } + + @Override + public ResourceID getResourceID() { + return resourceID; + } + + public long getAttempt() throws Exception { + Matcher m = TASK_MANAGER_POD_PATTERN.matcher(resourceID.toString()); + boolean mat = m.find(); + if (mat) { + return Long.parseLong(m.group(1)); + } else { + throw new Exception("Error to parse KubernetesWorkerNode from " + resourceID.toString()); Review comment: nit: `(...from {}, resourceID)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
