zhuzhurk commented on a change in pull request #10427: [FLINK-14566] Enable to
get/set whether an operator uses managed memory
URL: https://github.com/apache/flink/pull/10427#discussion_r354173514
##########
File path:
flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
##########
@@ -136,6 +138,14 @@ public static int getNewNodeId() {
*/
private ResourceSpec preferredResources = ResourceSpec.DEFAULT;
+ /**
+ * This weight indicates how much this transformation relies on managed
memory, so that
+ * transformation highly relies on managed memory would be able to
acquire more managed
+ * memory in runtime (linear association). Note that it only works in
cases of UNKNOWN
+ * resources.
+ */
+ private int managedMemoryWeight = DEFAULT_MANAGED_MEMORY_WEIGHT;
Review comment:
I think a valid approach would be supporting users to set a environment wide
default resources other than UNKNOWN, so that after stream graph is built,
users (including sql) would not need to check which resources/weight is not
specified and needs to be overriden with a user wanted default value (what is
the current case in ExecutorUtils#setBatchProperties).
However, we cannot take this approach for now since resources setting is not
open to external users yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
