aljoscha commented on a change in pull request #10408: [FLINK-14992][client]
Add job listener to execution environments
URL: https://github.com/apache/flink/pull/10408#discussion_r354195543
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java
##########
@@ -126,7 +126,7 @@ private Configuration fromPackagedProgram(final
PackagedProgram program, final i
*/
@Test
public void testDetachedMode() throws Exception{
- final ClusterClient<?> clusterClient = new
MiniClusterClient(new Configuration(), MINI_CLUSTER_RESOURCE.getMiniCluster());
+ final ClusterClient<MiniClusterClient.MiniClusterId>
clusterClient = new MiniClusterClient(new Configuration(),
MINI_CLUSTER_RESOURCE.getMiniCluster());
Review comment:
Does adding the type here instead of `?` solve anything? It seems it just
makes the code less readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
