zhuzhurk commented on a change in pull request #10427: [FLINK-14566] Enable to
get/set whether an operator uses managed memory
URL: https://github.com/apache/flink/pull/10427#discussion_r354210643
##########
File path:
flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java
##########
@@ -136,6 +138,14 @@ public static int getNewNodeId() {
*/
private ResourceSpec preferredResources = ResourceSpec.DEFAULT;
+ /**
+ * This weight indicates how much this transformation relies on managed
memory, so that
+ * transformation highly relies on managed memory would be able to
acquire more managed
+ * memory in runtime (linear association). Note that it only works in
cases of UNKNOWN
+ * resources.
+ */
+ private int managedMemoryWeight = DEFAULT_MANAGED_MEMORY_WEIGHT;
Review comment:
>> And image user write an operator which using manage memory, and he
believe there is only one operator to use manage memory, that is his operator.
But if he use DataStream/DataSet api, whatever operators including
map/source... these operators will rob his memories.
The weight is not a public interface and users cannot set it. So if the user
uses the fraction, 0 default value will always result in 0 managed memory
fraction, even if the operator requires managed memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
