NicoK opened a new pull request #10437: [FLINK-15068][rocksdb] stop writing to 
RocksDB logs by default
URL: https://github.com/apache/flink/pull/10437
 
 
   ## What is the purpose of the change
   
   With Flink's default settings for RocksDB, it will write a `LOG` file (not 
the WAL, but pure logging statements) into the data folder. Besides periodic 
statistics, it will log compaction attempts, new memtable creations, flushes, 
etc. This file grows indefinitely and may fill the disk without this log being 
actually used anywhere (it will be deleted with the job anway).
   
   With this PR, we are effectively disabling the log by default. If anyone 
wants to retain it, it can be re-configured at will providing an own 
`OptionsFactory`.
   
   ## Brief change log
   
   - change the default RocksDB configuration for all `PredefinedOptions`
   so that they use log level `HEADER_LEVEL`
   - disable periodic statistics dumps to the `LOG` file
   - hotfix the description of the `DefaultConfigurableOptionsFactory`
   
   ## Verifying this change
   
   I ran a Flink cluster with these changes and the `LOG` file now only 
contains some headers and is then never written to again. Normal behaviour is 
otherwise covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **JavaDocs**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to