[ 
https://issues.apache.org/jira/browse/FLINK-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988774#comment-16988774
 ] 

Till Rohrmann commented on FLINK-15058:
---------------------------------------

Concerning your first comment [~xintongsong], Gary and me discussed this 
yesterday as well. The problem occurs if the user has set no memory 
configuration option. 

One option to solve this problem would be to check the free heap size if none 
of the three memory settings is configured and set the total flink memory to 
this value. What I do not like about this approach is that it introduces 
implicit behaviour and magic which is hard for users to understand. 

However, I'm not entirely sure how many Flink users would actually run into 
this problem. Per default {{flink-conf.yaml}} will have a memory configuration 
option set. Moreover, one could also argue that not setting any memory size is 
actually an illegal configuration and prevents users from shooting themselves 
in the foot. For example, I could imagine that users start a pod with 10 GB but 
forget to set the process memory to 10 GB. If the default value with which the 
JVM is started would be 1 GB, then we would waste 9 GB of memory. By failing 
early, we would make them aware of this.

> Log required config keys if TaskManager memory configuration is invalid
> -----------------------------------------------------------------------
>
>                 Key: FLINK-15058
>                 URL: https://issues.apache.org/jira/browse/FLINK-15058
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Currently the error message is
> {noformat}
> Either Task Heap Memory size and Managed Memory size, or Total Flink Memory 
> size, or Total Process Memory size need to be configured explicitly
> {noformat}
> However, it would be good to immediately see which config keys are expected 
> to be configured.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to