walterddr commented on a change in pull request #8746:
[hotfix][FLINK-11120][table]fix the bug of timestampadd handles time
URL: https://github.com/apache/flink/pull/8746#discussion_r354418398
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -3572,6 +3572,26 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"'2016-03-31'.toDate - 1.week",
"timestampadd(WEEK, -1, date '2016-03-31')",
"2016-03-24")
+
+ // TIMESTAMPADD with time; returns a time value.The interval is positive.
Review comment:
```suggestion
// test TIMESTAMPADD with positive time interval in various granularity.
```
I will fix this and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
