wangxlong commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369#issuecomment-562458580 > > > @wangxlong thanks for your contribution. Changes look good to me. It would be better if you can write a test for the specific case and I think it is somewhat necessary :-) > > > > > > Hi @TisonKun . I am sorry for replying late. I found ClassLoader#loadClass will invoke findClass when loadClass failed. So it is not necessary to invoke findClass by ourselves. What do you think of it? > > OK I think it is the reason why we tend to add a test for bisect the behavior :-) > > IIUC you mean that with or without this patch, classloading always works as expected, right? > > If so, it'd better we just close this ticket. Yes, you are right. I will close this ticket. Thanks you for your review.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
