hequn8128 commented on a change in pull request #10377: [FLINK-15001] [table-planner-blink] The digest of sub-plan reuse should contain retraction traits for stream physical nodes URL: https://github.com/apache/flink/pull/10377#discussion_r355169122
########## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DagOptimizationTest.xml ########## @@ -212,7 +211,8 @@ Sink(name=[`default_catalog`.`default_database`.`appendSink1`], fields=[a, b1], Sink(name=[`default_catalog`.`default_database`.`appendSink2`], fields=[a, b1], updateAsRetraction=[false], accMode=[Acc]) +- Union(all=[true], union=[a1, b1], updateAsRetraction=[false], accMode=[Acc]) - :- Reused(reference_id=[1]) + :- Calc(select=[a AS a1, b AS b1], updateAsRetraction=[false], accMode=[Acc]) Review comment: It is right that updateAsRetraction is false for this Calc, but the updateAsRetraction is not right for its input Calc which should also be false. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
