[ https://issues.apache.org/jira/browse/FLINK-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998340#comment-14998340 ]
ASF GitHub Bot commented on FLINK-2901: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1306#discussion_r44388274 --- Diff: flink-tests/src/test/java/org/apache/flink/test/iterative/IterativeKMeansITCase.java --- @@ -1,62 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - - -package org.apache.flink.test.iterative; - -import java.util.ArrayList; -import java.util.List; - -import org.apache.flink.api.common.Plan; -import org.apache.flink.test.recordJobs.kmeans.KMeansBroadcast; -import org.apache.flink.test.testdata.KMeansData; -import org.apache.flink.test.util.RecordAPITestBase; - - -public class IterativeKMeansITCase extends RecordAPITestBase { --- End diff -- We should check if there is another test in the test suite that uses a broadcast variable in a bulk iteration. If not, we should implement such a test (not necessarily reimplementing the KMeans program). > Several flink-test ITCases depend on Record API features > -------------------------------------------------------- > > Key: FLINK-2901 > URL: https://issues.apache.org/jira/browse/FLINK-2901 > Project: Flink > Issue Type: Sub-task > Components: Tests > Affects Versions: 0.10 > Reporter: Fabian Hueske > Assignee: Chesnay Schepler > > There are several ITCases and utility classes in {{flink-tests}} that depend > on the Record API including: > - ITCases for Record API operators in > {{flink-tests/src/test/java/org/apache/flink/test/operators}} > - ITCases for Record API programs in > {{flink-tests/src/test/java/org/apache/flink/test/recordJobTests}} > - Record API programs in > {{flink-tests/src/test/java/org/apache/flink/test/recordJobs}} > - Several ITCases for iterations in > {{flink-tests/src/test/java/org/apache/flink/test/iterative}} > - Tests for job canceling in > {{flink-tests/src/test/java/org/apache/flink/test/cancelling}} > - Test for failing jobs in > {{flink-tests/src/test/java/org/apache/flink/test/failingPrograms/TaskFailureITCase}} > - Optimizer tests in > {{flink-tests/src/test/java/org/apache/flink/test/optimizer}} > - Accumulator test in > {{flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorIterativeITCase}} > - Broadcast test in > {{flink-tests/src/test/java/org/apache/flink/test/broadcastvasr/BroadcastBranchingITCase}} > - distributed cache test in > {{flink-tests/src/test/java/org/apache/flink/test/distributedCache/DistributedCacheTest}} > and probably a few more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)