[
https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995321#comment-16995321
]
Yang Wang edited comment on FLINK-15179 at 12/13/19 4:28 AM:
-------------------------------------------------------------
[~trohrmann] Thanks a lot for your comments.
[~kkl0u] I think we have reached some basic agreements and could move forward.
# The cli options will be deprecated in the future, use config options instead.
# Remove cli options for `kubernetes-session.sh` now so that we will not have
any backward compatibility for kubernetes
# Each executor could has its own help message
# Need more discussion about yarn cli options and properties file
After this change, the commands of starting a session cluster and submitting a
flink job into it will like following.
{code:java}
./bin/kubernetes-session.sh -Dkubernetes.cluster-id=flink-native-k8s-session-1 \
-Dflink:flink-1.10-SNAPSHOT-k8s \
-Djobmanager.heap.size=4096m -Dtaskmanager.memory.total-process.size=4096m \
-Dtaskmanager.numberOfTaskSlots=4
{code}
{code:java}
./bin/flink run -d -e kubernetes-session-cluster \
-Dkubernetes.cluster-id=flink-native-k8s-session-1 \
examples/streaming/WindowJoin.jar
{code}
was (Author: fly_in_gis):
[~trohrmann] Thanks a lot for your comments.
[~kkl0u] I think we have reached some basic agreements and could move forward.
# The cli options will be deprecated in the future, use config options instead.
# Remove cli options for `kubernetes-session.sh` now so that we will not have
any backward compatibility for kubernetes
# Each executor could has its own help message
# Need more discussion about yarn cli options and properties file
> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
> Key: FLINK-15179
> URL: https://issues.apache.org/jira/browse/FLINK-15179
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of FLIP-73, all command line options are mapped to config options.
> Given this 1-to-1 mapping, the Kubernetes command line could simply forward
> the command line arguments to ConfigOptions directly, instead of introducing
> new command line options. In this case, the user is expected to simply write:
>
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D
> kubernetes.container.image=MY_IMAGE ...}}
> and the CLI will parse the -e to figure out the correct
> {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the
> config options specified with {{-D}}.
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply
> forward the specified parameters to the executors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
