bowenli86 commented on issue #10577: [FLINK-15256][hive] HiveModuleFactory should take hive-version as required supported property URL: https://github.com/apache/flink/pull/10577#issuecomment-565650334 > The changes look fine, but could you explain why we cannot infer the version when it's missing? We did the familiar thing when loading hiveshims. good question. I'm thinking we should remove the version inference in HiveCatalog too. We support lots of hive versions now, users may not read the doc carefully and may assume we can just fit into their hive version magically somehow. Say they use the default hive version 2.3.4 but their actual version is 1.2.x, they may run into issues and the errors won't show the root cause. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
