[ 
https://issues.apache.org/jira/browse/FLINK-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

lining updated FLINK-14422:
---------------------------
    Description: 
* add getTotalMemorySize and in getAvaliableMemorySize NetworkBufferPool 

{code:java}
public long getTotalMemorySize() {
    return 1L * getTotalNumberOfMemorySegments() * memorySegmentSize;
}

public long getAvaliableMemorySize() {
    return 1L * getNumberOfAvailableMemorySegments() * memorySegmentSize;
}
{code}
 
 * update NettyShuffleMetricFactory#registerShuffleMetrics

{code:java}
private static final String METRIC_TOTAL_MEMORY_SEGMENT_TOTALCAPACITY = 
"TotalMemoryCapacity";
private static final String METRIC_TOTAL_MEMORY_SEGMENT_AVALIABLEMEMORY = 
"AvaliableMemory";
private static void registerShuffleMetrics(
    String groupName,
    MetricGroup metricGroup,
    NetworkBufferPool networkBufferPool) {
    MetricGroup networkGroup = metricGroup.addGroup(groupName);
    networkGroup.<Integer, Gauge<Integer>>gauge(METRIC_TOTAL_MEMORY_SEGMENT,
                                                
networkBufferPool::getTotalNumberOfMemorySegments);
    networkGroup.<Integer, Gauge<Integer>>gauge(METRIC_AVAILABLE_MEMORY_SEGMENT,
                                                
networkBufferPool::getNumberOfAvailableMemorySegments);
    networkGroup.<Long, 
Gauge<Long>>gauge(METRIC_TOTAL_MEMORY_SEGMENT_TOTALCAPACITY,
                                          
networkBufferPool::getTotalMemorySize);
    networkGroup.<Long, 
Gauge<Long>>gauge(METRIC_TOTAL_MEMORY_SEGMENT_AVALIABLEMEMORY,
                                          
networkBufferPool::getAvaliableMemorySize);
}
{code}

  was:
* add getTotalMemorySize and in getAvaliableMemorySize NetworkBufferPool 

{code:java}
        public long getTotalMemorySize() {
                return 1L * getTotalNumberOfMemorySegments() * 
memorySegmentSize;
        }

        public long getAvaliableMemorySize() {
                return 1L * getNumberOfAvailableMemorySegments() * 
memorySegmentSize;
        }
{code}


> Add metric for shuffle memory
> -----------------------------
>
>                 Key: FLINK-14422
>                 URL: https://issues.apache.org/jira/browse/FLINK-14422
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Task
>            Reporter: lining
>            Priority: Major
>
> * add getTotalMemorySize and in getAvaliableMemorySize NetworkBufferPool 
> {code:java}
> public long getTotalMemorySize() {
>     return 1L * getTotalNumberOfMemorySegments() * memorySegmentSize;
> }
> public long getAvaliableMemorySize() {
>     return 1L * getNumberOfAvailableMemorySegments() * memorySegmentSize;
> }
> {code}
>  
>  * update NettyShuffleMetricFactory#registerShuffleMetrics
> {code:java}
> private static final String METRIC_TOTAL_MEMORY_SEGMENT_TOTALCAPACITY = 
> "TotalMemoryCapacity";
> private static final String METRIC_TOTAL_MEMORY_SEGMENT_AVALIABLEMEMORY = 
> "AvaliableMemory";
> private static void registerShuffleMetrics(
>     String groupName,
>     MetricGroup metricGroup,
>     NetworkBufferPool networkBufferPool) {
>     MetricGroup networkGroup = metricGroup.addGroup(groupName);
>     networkGroup.<Integer, Gauge<Integer>>gauge(METRIC_TOTAL_MEMORY_SEGMENT,
>                                                 
> networkBufferPool::getTotalNumberOfMemorySegments);
>     networkGroup.<Integer, 
> Gauge<Integer>>gauge(METRIC_AVAILABLE_MEMORY_SEGMENT,
>                                                 
> networkBufferPool::getNumberOfAvailableMemorySegments);
>     networkGroup.<Long, 
> Gauge<Long>>gauge(METRIC_TOTAL_MEMORY_SEGMENT_TOTALCAPACITY,
>                                           
> networkBufferPool::getTotalMemorySize);
>     networkGroup.<Long, 
> Gauge<Long>>gauge(METRIC_TOTAL_MEMORY_SEGMENT_AVALIABLEMEMORY,
>                                           
> networkBufferPool::getAvaliableMemorySize);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to