[
https://issues.apache.org/jira/browse/FLINK-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000780#comment-17000780
]
lining commented on FLINK-15345:
--------------------------------
Referring to the
[code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java#L633-L638],
the prior execution will be put in the prior executions when restarting. Then
it will create a new execution whose attempt number is the prior execution's
attempt number plus one. As the code link is shown in the description, if the
attempt number of current execution is 2, there should be two previous attempts
in prior executions.
> CurrentExecution and priorExecutions are inconsistent in the test case
> ----------------------------------------------------------------------
>
> Key: FLINK-15345
> URL: https://issues.apache.org/jira/browse/FLINK-15345
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / REST, Tests
> Reporter: lining
> Priority: Minor
>
> When the length of priorExecutions does not exceed the value of the
> configuration item jobmanager.execution.attempts-history-size, the attempt
> should be equal to the length of priorExecutions. So [code in
> JobExceptionsHandlerTest|https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandlerTest.java#L104-L121]
> and [code in
> SubtaskCurrentAttemptDetailsHandlerTest|https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/SubtaskCurrentAttemptDetailsHandlerTest.java#L94-L111]
> are wrong, we need to update the attempt to 0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
