xintongsong commented on a change in pull request #10672:
[FLINK-15373][core][config] Update descriptions for framework / task off-heap
memory config options
URL: https://github.com/apache/flink/pull/10672#discussion_r361265641
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -275,8 +276,9 @@
public static final ConfigOption<String> TASK_OFF_HEAP_MEMORY =
key("taskmanager.memory.task.off-heap.size")
.defaultValue("0b")
- .withDescription("Task Heap Memory size for
TaskExecutors. This is the size of off heap memory (JVM direct"
- + " memory or native memory) reserved for user
code.");
+ .withDescription("Task Off-Heap Memory size for
TaskExecutors. This is the size of off heap memory (JVM"
+ + " direct memory and native memory) reserved
for user code. The configured value will be fully counted"
Review comment:
Nice catch, thanks. Comment addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
