bowenli86 commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink… URL: https://github.com/apache/flink/pull/10625#issuecomment-569113636 > > Consider using `getPrimitiveWritableConstantObjectInspector`? > > I tried, and it worked. > > @bowenli86 IIRC, you chose to use java constant object inspectors for constant arguments. Is there a reason that we should prefer java to writable object inspectors? I recall that I might choose java constant oi over writable constant oi because WritableConstantObjectInspector may auto box the java constant which seems not necessary at that time. If auto boxing turns out to be beneficial, we should use it. BTW, I researched Hive 3.x code base, seems java constant oi is not used anymore, and writable constant oi is the standard now. We should be good to switch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
