lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive]
HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361971286
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java
##########
@@ -354,6 +354,9 @@ public CatalogColumnStatisticsDataDate
toFlinkDateColStats(ColumnStatisticsData
@Override
public Object toHiveTimestamp(Object flinkTimestamp) {
+ if (flinkTimestamp == null) {
Review comment:
I think we can let `HiveObjectConversion` rely on `HiveShim` to handle
nulls. So we don't need the null check in both of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
