wuchong commented on a change in pull request #10714: [FLINK-15409]Add
semicolon after WindowJoinUtil#generateJoinFunction
'$collectorTerm.collect($joinedRow)' statement
URL: https://github.com/apache/flink/pull/10714#discussion_r362145291
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowJoinUtil.scala
##########
@@ -127,7 +127,7 @@ object WindowJoinUtil {
case None =>
s"""
|$buildJoinedRow
- |$collectorTerm.collect($joinedRow)
+ |$collectorTerm.collect($joinedRow);
Review comment:
I looked into the code and find that we will never enter this branch under
the current implementation, because `otherCondition` is never null (always
contains join key). That means we can't reproduce this problem currenlty. If we
want to reproduce this probem, we have to refactor the window join (esp.
`otherCondition`). However, this is a major work.
My suggestion would be: simply add the semicolon and do not add tests, and
refactor window join in following issues, I just create FLINK-15441 to track
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
