lirui-apache commented on a change in pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns URL: https://github.com/apache/flink/pull/10704#discussion_r362168806
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java ########## @@ -953,7 +954,7 @@ private static CatalogPartitionSpec createPartitionSpec(String hivePartitionName Map<String, String> spec = new HashMap<>(partKeyVals.length); for (String keyVal : partKeyVals) { String[] kv = keyVal.split("="); - spec.put(kv[0], kv[1]); + spec.put(unescapePathName(kv[0]), unescapePathName(kv[1])); Review comment: Not related to this PR, but maybe we need more tests for this, e.g. string partition columns with special characters. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services