wangyang0918 commented on a change in pull request #10728: [FLINK-15437][yarn]
Apply dynamic properties early on client side.
URL: https://github.com/apache/flink/pull/10728#discussion_r362418438
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -369,6 +372,14 @@ public Configuration
applyCommandLineOptionsToConfiguration(CommandLine commandL
effectiveConfiguration.setInteger(TaskManagerOptions.NUM_TASK_SLOTS,
Integer.parseInt(commandLine.getOptionValue(slots.getOpt())));
}
+ dynamicPropertiesEncoded = encodeDynamicProperties(commandLine);
+ if (dynamicPropertiesEncoded != null &&
!dynamicPropertiesEncoded.isEmpty()) {
Review comment:
I think the null check is unnecessary since the `encodeDynamicProperties`
will always return a `NonNull` value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
