wuchong commented on a change in pull request #10745: [FLINK-15445][connectors/jdbc] JDBC Table Source didn't work for Type… URL: https://github.com/apache/flink/pull/10745#discussion_r362693737
########## File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io.jdbc; + +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.table.api.EnvironmentSettings; +import org.apache.flink.table.api.java.StreamTableEnvironment; +import org.apache.flink.table.runtime.utils.StreamITCase; +import org.apache.flink.test.util.AbstractTestBase; +import org.apache.flink.types.Row; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.List; + + +/** + * ITCase for {@link JDBCTableSource}. + */ +public class JDBCTableSourceITCase extends AbstractTestBase { + + public static final String DRIVER_CLASS = "org.apache.derby.jdbc.EmbeddedDriver"; + public static final String DB_URL = "jdbc:derby:memory:test"; + public static final String INPUT_TABLE = "jdbcSource"; + + @Before + public void before() throws ClassNotFoundException, SQLException { + System.setProperty("derby.stream.error.field", JDBCTestBase.class.getCanonicalName() + ".DEV_NULL"); + Class.forName(DRIVER_CLASS); + + try ( + Connection conn = DriverManager.getConnection(DB_URL + ";create=true"); + Statement statement = conn.createStatement()) { + statement.executeUpdate("CREATE TABLE " + INPUT_TABLE + " (" + + "id BIGINT NOT NULL," + + "timestamp6_col TIMESTAMP, " + + "time_col TIME, " + + "decimal_col DECIMAL(10, 4))"); + statement.executeUpdate("INSERT INTO " + INPUT_TABLE + " VALUES (" + + "1, TIMESTAMP('2020-01-01 15:35:00.123456'), TIME('15:35:00'), 100.1234)"); + statement.executeUpdate("INSERT INTO " + INPUT_TABLE + " VALUES (" + + "2, TIMESTAMP('2020-01-01 15:36:01.123456'), TIME('15:36:01'), 101.1234)"); + } + } + + @After + public void clearOutputTable() throws Exception { + Class.forName(DRIVER_CLASS); + try ( + Connection conn = DriverManager.getConnection(DB_URL); + Statement stat = conn.createStatement()) { + stat.execute("DROP TABLE " + INPUT_TABLE); + } + } + + @Test + public void testJDBCSource() throws Exception { + StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); + EnvironmentSettings envSettings = EnvironmentSettings.newInstance() + .useBlinkPlanner() + .inStreamingMode() + .build(); + StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, envSettings); + + tEnv.sqlUpdate( + "CREATE TABLE " + INPUT_TABLE + "(" + + "id BIGINT," + + "timestamp6_col TIMESTAMP(6)," + + "time_col TIME," + + "decimal_col DECIMAL(10, 4)" + Review comment: Could you add full list of types to have a full coverage? For example, add `TIMESTAMP`, `TIMESTAMP(9)`, `DECIMAL(38, 18)`, `DECIMAL`, `FLOAT` (we have a bug for float before), etc... I would also suggest to combine source integrate tests and sink integrate tests, e.g. read from collections and write into jdbc using SQL, and read from JDBC to verify the result. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
