JingsongLi commented on a change in pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363162293
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java
##########
@@ -1063,8 +1063,8 @@ public static String toBase64(byte[] bytes){
return Base64.getEncoder().encodeToString(bytes);
}
- public static byte[] fromBase64(BinaryString bs){
- return Base64.getDecoder().decode(bs.getBytes());
+ public static String fromBase64(BinaryString bs){
+ return new String(Base64.getDecoder().decode(bs.getBytes()));
Review comment:
We can not use `new String` directly, because we don't know the default
coder must be UTF-8.
Maybe we can use `BinaryString.fromBytes`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
