KarmaGYZ commented on a change in pull request #10742: [FLINK-15442] Harden the
Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363574005
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -36,7 +36,7 @@ function setup_kafka_dist {
mkdir -p $TEST_DATA_DIR
KAFKA_URL="https://archive.apache.org/dist/kafka/$KAFKA_VERSION/kafka_2.11-$KAFKA_VERSION.tgz";
echo "Downloading Kafka from $KAFKA_URL"
- curl "$KAFKA_URL" --retry 10 --retry-max-time 120 > $TEST_DATA_DIR/kafka.tgz
+ retry_times 5 0 "curl ${KAFKA_URL} --retry 10 --retry-max-time 120 --output
${TEST_DATA_DIR}/kafka.tgz"
Review comment:
Thanks for mention this. Yes, we could rely on the curl native mechanism.
However, after reading the [curl
manual](https://curl.haxx.se/docs/manpage.html). I found it's better to add the
`--retry-delay` configure here to disable the exponential backoff mechanism.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
