carp84 commented on a change in pull request #10820:
[FLINK-15512][statebackend] Refactor the mechanism to calculate the cache
capacity shared among RocksDB instance(s)
URL: https://github.com/apache/flink/pull/10820#discussion_r365227931
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainerTest.java
##########
@@ -145,12 +160,34 @@ public void
testGetColumnFamilyOptionsWithSharedResources() throws Exception {
container.close();
}
+ @Test
+ public void testCreateSharedResourcesWithExpectedCapacity() throws
Exception {
Review comment:
The design of this test seems to be tightly coupled with the implementation,
while it's true that we cannot get the actual cache size through RocksDB's JNI
(not exposed so reflection couldn't get it, either)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
